test stderr for error messages in integration test for publishing pac…

…kages with invalid names, #108
caolan · Dec 14, 2012 · 5ebd2a0 · 5ebd2a0
1 parent be8df1e
commit 5ebd2a0
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 10 deletions.
diff --git a/lib/logger.js b/lib/logger.js
@@ -105,7 +105,7 @@ exports.error = function (err) {
     if (err.stack) {
         msg = err.stack.replace(/^Error: /, '');
     }
-    console.log(red(bold('Error: ') + msg));
+    console.error(red(bold('Error: ') + msg));
 };
 
 

diff --git a/test/integration/test-publish.js b/test/integration/test-publish.js
@@ -92,17 +92,27 @@ exports['publish to command-line repo'] = function (test) {
 exports['publish with invalid .js package name'] = function (test) {
     test.expect(1);
     process.chdir('./fixtures/package-three-invalid-extjs');
-    utils.runJam(['publish'], {env: ENV}, function (err, stdout, stderr) {
-        test.ok(err);
-        test.done();
-    });
+    utils.runJam(['publish'], {env: ENV, expect_error: true},
+        function (err, stdout, stderr) {
+            if (err) {
+                return test.done(err);
+            }
+            test.ok(/Invalid name property/.test(stderr));
+            test.done();
+        }
+    );
 };
 
 exports['publish with invalid package name characters'] = function (test) {
     test.expect(1);
     process.chdir('./fixtures/package-three-invalid-characters');
-    utils.runJam(['publish'], {env: ENV}, function (err, stdout, stderr) {
-        test.ok(err);
-        test.done();
-    });
+    utils.runJam(['publish'], {env: ENV, expect_error: true},
+        function (err, stdout, stderr) {
+            if (err) {
+                return test.done(err);
+            }
+            test.ok(/Invalid name property/.test(stderr));
+            test.done();
+        }
+    );
 };
diff --git a/test/utils.js b/test/utils.js
@@ -22,7 +22,7 @@ exports.runJam = function (args, /*optional*/opts, callback) {
         stderr += data.toString();
     });
     jam.on('exit', function (code) {
-        if (code !== 0) {
+        if (code !== 0 && !opts.expect_error) {
             console.log(['Jam command failed', args]);
             console.log(stdout);
             console.log(stderr);