Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tap@12 #356

Merged
merged 3 commits into from
Jul 9, 2018
Merged

Use tap@12 #356

merged 3 commits into from
Jul 9, 2018

Conversation

brodybits
Copy link
Contributor

Resolves npm audit issues - wanted to resolve dev audit issues on Cordova xcode package (heavy use of nodeunit, which makes it highly difficult to port away).

Considering that this project has been marked deprecated and last npm publish was 8 months ago, I will request publish rights according to https://www.npmjs.com/policies/disputes.

@mreinstein
Copy link
Collaborator

I don't have admin privs to add/remove contributors. pinging @caolan

@caolan
Copy link
Owner

caolan commented Jul 9, 2018

@brodybits if this is a one-off change I will publish a new version for you (and please keep the deprecation notice in your patch). Alternatively, if you're volunteering for ongoing maintenance of the project we can look into granting you publish rights after discussing your future plans.

Christopher J. Brody added 2 commits July 9, 2018 09:52
* blank line
* Add Node.js versions:
  - 10.x (explicit)
  - 8.x
  - 6.14.x
  - 4.9.x (4.9.1)
@brodybits brodybits force-pushed the tap-12 branch 2 times, most recently from 56eeca1 to 98f5a33 Compare July 9, 2018 14:45
@mreinstein
Copy link
Collaborator

In terms of the amount of sheer work, converting the tests in xcode to some other testing framework is significantly less work than the maintenance burden of bringing nodeunit into modernity. There is a lot of hidden work there.

Just my 2¢ …

@brodybits
Copy link
Contributor Author

I just rebased and pushed the changes without removing the deprecation notice, would like to see it published asap (today if possible). FYI it seems to pass its own test suite on really old Node.js back to 0.12, though with a few ugly engine warnings.

FYI the request for publishing rights that I sent by email with cc support@npmjs.com still stands according to https://www.npmjs.com/policies/disputes. Purpose is to keep the dependencies up to date, fix the worst of the documentation errors, and resolve other critical issues that may come up until we are able to finish porting the tests out (hope I don't have to rush it).

In terms of GitHub I can do the maintenance here or in a fork.

I would also be fine in case you guys decide to nominate someone else to take over npm publish, suggest you would respond to my email in that case.

@caolan caolan merged commit cd773a2 into caolan:master Jul 9, 2018
@caolan
Copy link
Owner

caolan commented Jul 9, 2018

@brodybits v0.11.3 has been published to NPM. Thanks for your pull request.

@caolan
Copy link
Owner

caolan commented Jul 9, 2018

When you're ready to update your test framework I suggest looking at Mocha's "exports" UI: https://mochajs.org/#exports. It's based on the nodeunit style and should be easy to port your test suite to.

@brodybits
Copy link
Contributor Author

Thanks for your help with the quick merge and publish, works for cordova-node-xcode.

I will look into Mocha Exports or maybe just using tap(e) in the future. I found an interesting article at: https://medium.com/javascript-scene/why-i-use-tape-instead-of-mocha-so-should-you-6aa105d8eaf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants