-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use package name for product ORD IDs. #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenario:
Removing the sample .cdsrc JSON configuration for ord namespace and asyncapi namesapce,
The packageJSON name has special characters ( for example @cap-js/ordsample) the special character gets added and the namespace becomes cap-jsord
for which the validator throws an error.
The special characters are also to be escaped here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here if the title and short description are same the validator throws an error.
@Fannon you could help us better too to decide what to we do about this.
This rule will only cause issues when publishing to the Business Accelerator Hub, if you just have But I think it would still be better to avoid this problem in the first place, so if SAP collagues use this plugin, they don't have to rework. Maybe we can prefix the shortDescription with something like |
Tested and looks good! |
Addressing
package.name.replace(/@/,'').replace(/\//g,’')
, unless explicitly configured in cds.env.ord.namespacepackage.name.replace(/@/,'').replace(/\//g,'.')
"vendor": "customer:vendor:customer:”
package.name.replace(/@/,'').replace(/\//g,' ')
package.name.replace(/@/,'').replace(/\//g,' ')
- Description for + "package name"from #38