Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): capacitor 3 dependency update, fix(android): implement @PermissionCallback #55

Conversation

dennisameling
Copy link
Contributor

@dennisameling dennisameling commented Mar 1, 2021

Updates the capacitor-3 branch to work correctly with the latest Capacitor beta version 🚀

Also implements @PermissionCallback in Android which was added in beta-2

@dennisameling dennisameling changed the base branch from capacitor-3 to main March 4, 2021 15:30
@pwespi
Copy link
Member

pwespi commented Mar 6, 2021

Thanks a lot for this. 🚀

I added your commits to the capacitor-3 branch. However, there are a few more things I want to do before merging into into main.

@dennisameling
Copy link
Contributor Author

We did a quick check on iOS as well and it seems to be crashing after updating to this latest version, so we'll need to investigate this further. Let me know if you want me to help with anything 🚀

@pwespi
Copy link
Member

pwespi commented Mar 6, 2021

Could you try again with the latest capacitor-3 branch? I added a fix for iOS (and another for web). Testing and reporting issues is already a big help. Thanks! :)

@pwespi
Copy link
Member

pwespi commented Mar 7, 2021

I'm closing this PR as #15 has been merged with these changes and more.

I also released the Capacitor v3 version of this plugin under the next tag on npm. If you find any bugs/crashes with it, feel free to open an issue. Thanks.

@pwespi pwespi closed this Mar 7, 2021
@dennisameling
Copy link
Contributor Author

We'll check it out in the coming day or two! Thanks so much for your work on this 🚀

@dennisameling
Copy link
Contributor Author

First tests are looking good, haven't come across any issues so far! Thank you 🎉

@pwespi
Copy link
Member

pwespi commented Mar 9, 2021

That's good to hear. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants