fix(authentication): empty verification ID on phone auth (#520)

* fix(authentication): iOS: do not ignore errors in verifyPhoneNumber * remove exclamation mark * Update khaki-maps-carry.md --------- Co-authored-by: Robin Genz <mail@robingenz.dev>
capawesome-team · Dec 14, 2023 · 0e0bc8a · 0e0bc8a
1 parent b568914
commit 0e0bc8a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.changeset/khaki-maps-carry.md b/.changeset/khaki-maps-carry.md
@@ -0,0 +1,5 @@
+---
+'@capacitor-firebase/authentication': patch
+---
+
+fix(ios): empty verification ID on phone auth
diff --git a/packages/authentication/ios/Plugin/Handlers/PhoneAuthProviderHandler.swift b/packages/authentication/ios/Plugin/Handlers/PhoneAuthProviderHandler.swift
@@ -39,8 +39,13 @@ class PhoneAuthProviderHandler: NSObject {
 
     private func verifyPhoneNumber(_ options: SignInWithPhoneNumberOptions) {
         PhoneAuthProvider.provider()
-            .verifyPhoneNumber(options.getPhoneNumber(), uiDelegate: nil) { verificationID, _ in
-                self.pluginImplementation.handlePhoneCodeSent(verificationID ?? "")
+            .verifyPhoneNumber(options.getPhoneNumber(), uiDelegate: nil) { verificationID, error in
+                if let error = error {
+                    self.pluginImplementation.handlePhoneVerificationFailed(error)
+                } else {
+                    self.pluginImplementation.handlePhoneCodeSent(verificationID ?? "")
+                }
             }
     }
+
 }