Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication): empty verification ID on phone auth #520

Merged
merged 3 commits into from Dec 14, 2023
Merged

fix(authentication): empty verification ID on phone auth #520

merged 3 commits into from Dec 14, 2023

Conversation

DmitrySboychakov
Copy link
Contributor

@DmitrySboychakov DmitrySboychakov commented Dec 13, 2023 •
edited by robingenz

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #380

@robingenz robingenz added bug/fix Something isn't working package: authentication labels Dec 13, 2023
@robingenz robingenz added this to the v5.4.0 milestone Dec 13, 2023
@robingenz robingenz self-requested a review December 13, 2023 20:22
@robingenz robingenz added the platform: ios iOS platform label Dec 13, 2023
@robingenz robingenz changed the title fix(authentication): iOS: do not ignore errors in verifyPhoneNumber (#519) fix(authentication): empty verification ID on phone auth Dec 14, 2023
@robingenz robingenz merged commit 0e0bc8a into capawesome-team:main Dec 14, 2023
2 checks passed
@robingenz
Copy link
Member

@DmitrySboychakov Thank you for your contribution!

@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees

@DmitrySboychakov DmitrySboychakov

Labels
bug/fix Something isn't working package: authentication platform: ios iOS platform
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.

bug: SMS verification code not received and an empty verification ID
2 participants
@DmitrySboychakov @robingenz