Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgumentError: invalid option(s): known_hosts with net-ssh 3.0.2 #357

Closed
mattbrictson opened this issue Jun 17, 2016 · 1 comment · Fixed by #358
Closed

ArgumentError: invalid option(s): known_hosts with net-ssh 3.0.2 #357

mattbrictson opened this issue Jun 17, 2016 · 1 comment · Fixed by #358
Labels
bug?

Comments

@mattbrictson
Copy link
Member

I saw this reported on Stack Overflow, and it seems like a legitimate bug introduced in sshkit 1.11.0.

https://stackoverflow.com/questions/37865299/capistrano-error-invalid-optionss-known-hosts

To summarize: starting with sshkit 1.11.0, we now pass a :known_hosts option to net-ssh by default (see #339). Unfortunately it seems that not all versions of net-ssh allow this. And instead of ignoring the option, net-ssh raises this error, at least in net-ssh 3.0.2:

ArgumentError: invalid option(s): known_hosts

The solution seems to be to upgrade to net-ssh 3.1.1.

@byroot Does this bug report seem legitimate? What can we do to fix this issue (other than change our gemspec to require newer net-ssh, which seems drastic)?
@mattbrictson mattbrictson mentioned this issue Jun 17, 2016
Closed
@casperisfine
Copy link
Contributor

casperisfine commented Jun 17, 2016 •
edited
Loading

Hum, good point. I think we could check Net::SSH::VALID_OPTIONS, I'll PR something. https://github.com/net-ssh/net-ssh/blob/e884efe99fefe66eaddbd17b42b16c8112c6b9c5/lib/net/ssh.rb#L63

@casperisfine casperisfine mentioned this issue Jun 17, 2016
Merged
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 17, 2016
Update ruby-sshkit to 1.11.3.
3d7d2f5 
## [1.11.3][] (2016-09-16)

  * Fix known_hosts caching to match on the entire hostlist
    [PR #364](capistrano/sshkit#364) @byroot

## [1.11.2][] (2016-07-29)

### Bug fixes

  * Fixed a crash occurring when `Host@keys` was set to a non-Enumerable.
    @xavierholt [PR #360](capistrano/sshkit#360)

## [1.11.1][] (2016-06-17)

### Bug fixes

  * Fixed a regression in 1.11.0 that would cause
    `ArgumentError: invalid option(s): known_hosts` in some older versions of
    net-ssh. @byroot [#357](capistrano/sshkit#357)

## [1.11.0][] (2016-06-14)

### Bug fixes

  * Fixed colorized output alignment in Logger::Pretty. @xavierholt
    [PR #349](capistrano/sshkit#349)
  * Fixed a bug that prevented nested `with` calls
    [#43](capistrano/sshkit#43)

### Other changes

  * Known hosts lookup optimization is now enabled by default. @byroot

## 1.10.0 (2016-04-22)

  * You can now opt-in to caching of SSH's known_hosts file for a speed boost
    when deploying to a large fleet of servers. Refer to the
    [README](https://github.com/capistrano/sshkit/tree/v1.10.0#known-hosts-caching) for
    details. We plan to turn this on by default in a future version of SSHKit.
    [PR #330](capistrano/sshkit#330) @byroot
  * SSHKit now explicitly closes its pooled SSH connections when Ruby exits;
    this fixes `zlib(finalizer): the stream was freed prematurely` warnings
    [PR #343](capistrano/sshkit#343) @mattbrictson
  * Allow command map entries (`SSHKit::CommandMap#[]`) to be Procs
    [PR #310](capistrano/sshkit#310)
    @mikz

## 1.9.0

**Refer to the 1.9.0.rc1 release notes for a full list of new features, fixes,
and potentially breaking changes since SSHKit 1.8.1.** There are no changes
since 1.9.0.rc1.

## 1.9.0.rc1

### Potentially breaking changes

  * The SSHKit DSL is no longer automatically included when you `require` it.
    **This means you  must now explicitly `include SSHKit::DSL`.**
    See [PR #219](capistrano/sshkit#219) for details.
    @beatrichartz
  * `SSHKit::Backend::Printer#test` now always returns true
    [PR #312](capistrano/sshkit#312) @mikz

### New features

  * `SSHKit::Formatter::Abstract` now accepts an optional Hash of options
    [PR #308](capistrano/sshkit#308) @mattbrictson
  * Add `SSHKit::Backend.current` so that Capistrano plugin authors can refactor
    helper methods and still have easy access to the currently-executing Backend
    without having to use global variables.
  * Add `SSHKit.config.default_runner` options that allows to override default command runner.
    This option also accepts a name of the custom runner class.
  * The ConnectionPool has been rewritten in this release to be more efficient
    and have a cleaner internal API. You can still completely disable the pool
    by setting `SSHKit::Backend::Netssh.pool.idle_timeout = 0`.
    @mattbrictson @byroot [PR #328](capistrano/sshkit#328)

### Bug fixes

  * make sure working directory for commands is properly cleared after `within` blocks
    [PR #307](capistrano/sshkit#307)
    @steved
  * display more accurate string for commands with spaces being output in `Formatter::Pretty`
    [PR #304](capistrano/sshkit#304)
    @steved
    [PR #319](capistrano/sshkit#319) @mattbrictson
  * Fix a race condition experienced in JRuby that could cause multi-server
    deploys to fail. [PR #322](capistrano/sshkit#322)
    @mattbrictson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check for :known_hosts support in net-ssh
2 participants
@mattbrictson @casperisfine