Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Backend::Local initialize compatible with Backend::Netssh #163

Closed
wants to merge 1 commit into from

Conversation

seandilda
Copy link

This fix gives Backend::Local and Backend::Netssh the same initialize parameters. More specifically, this allows you to set
set :sshkit_backend, SSHKit::Backend::Local
in your config/deploy.rb for capistrano and have it successfully deploy locally.

@onceking
Copy link

Local#run also deviate from other backends.
others have

instance_exec(host, &@block)

but Local#run has:

instance_exec(&@block)

@AmirKremer
Copy link
Contributor

Does changing it to

instance_exec(host, &@block)

Could do any harm?

@leehambley
Copy link
Member

I'm not sure, honestly - if someone wants to feed back, I'd be happy to merge this, even if "deploy locally" is a bit of an illogical misnomer :)

@leehambley
Copy link
Member

does anyone active in this thread have an interest in seeing it merged, or I would close the PR?

@seandilda
Copy link
Author

I've worked around the workflow I was attempting by now. However, I'd still like to see it merged as it'd give me some useful deployment options going forward.

@leehambley
Copy link
Member

Thanks @seandilda could you rebase the branch so it'll merge cleanly?

@mattbrictson
Copy link
Member

I'm in the process of closing old/inactive PRs; pardon the noise. This PR seems to have been abandoned. Also, I think we're generally phasing out support for the local backend, so it probably would not be merged if it were submitted today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants