Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure user-land configured symfony-env is used in console task #20

Merged
merged 1 commit into from
Jul 29, 2014

Conversation

peterjmit
Copy link
Contributor

@peterjmit
Copy link
Contributor Author

@patrickli thanks for your input - I missed adding with symfony_env: fetch(:symfony_env) (before we were using default_env).

default_env was good because then we were covered for composer commands. Command map is also an option, I would like to keep it simple though!

@patrickli
Copy link

I have been looking at a solution to this. With some initial testing, it seems removing the line

fetch(:default_env).merge!(symfony_env: fetch(:symfony_env))

from lib/capistrano/symfony/defaults.rb and implement it as a before task on deploy:starting is the best way to go.

peterjmit added a commit that referenced this pull request Jul 29, 2014
Ensure user-land configured symfony-env is used in console task
@peterjmit peterjmit merged commit 9cfe20c into master Jul 29, 2014
@peterjmit peterjmit deleted the set-symfony-env branch July 29, 2014 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants