1.0.0.rc1 - Symfony 3 directory structure #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #49 with credit to Dmitrii Korotovskii (@korotovsky)
Checking that permission_method is not false is sufficient
|
Any news about this PR? I really want to deploy my sf3 application with Capistrano. |
|
@nicosomb the gem is available for you to test and your feedback would be appreciated! |
peterjmit
added a commit
that referenced
this pull request
Feb 24, 2016
1.0.0.rc1 - Symfony 3 directory structure
This was referenced Mar 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following #40, #31, #49, thank you @korotovsky for your contribution and I hope you don't mind rolling them into here.
The gem is available on rubygems for testing (https://rubygems.org/gems/capistrano-symfony/versions/1.0.0.rc1) and I will be looking to tag a v1.0.0 release by the end of the month.
See the changelog for details
TODO:
var_path, notapp_path)