Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to load subset #30

Closed
wants to merge 1 commit into from
Closed

add option to load subset #30

wants to merge 1 commit into from

Conversation

capital-G
Copy link
Owner

As proposed in #24 (comment)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@capital-G capital-G requested a review from telephon April 19, 2021 12:33
@capital-G
Copy link
Owner Author

ToDo:

  • If we work on a subset and run the drum extraction of the midi files we will also overwrite the already fully one with the subset one - one of the examples why the state management in jupyter is horrible because its all over the place, spammed with global variables. The problem is that caching on a subset is even more difficult because the subset must be fixed in order that the caching works as expected. Maybe instead of storing the stuff in memory we should write a metadata file but this is also not so nice... mh

@capital-G
Copy link
Owner Author

Obsolete with #33

@capital-G capital-G closed this Apr 22, 2021
@capital-G capital-G deleted the midi-subset branch April 26, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant