Change file descriptor to stderr if status more then zero #19
Conversation
|
This sounds reasonable to me. Would you be willing to sign the Contributors agreement found in the readme? |
|
@ckstettler , I will read this section of readme first. |
|
@ckstettler , done I accepted individual terms. But, what do you think, of adding this new behavior in the readme, before diving into this pr? |
|
@ckstettler , I already adjust in |
| |--output|Text string to echo if there is a match.|No. | ||
| |--output|Text string to echo if there is a match. | ||
|
|
||
| But if `--status` is more then 0, echo redirect message to stderr.|No. |
| local out | ||
| out=$($ECHO "$output" | $AWK 'BEGIN{FS="%%"}{ for (i=1;i<=NF;i++) {print $i}}') | ||
|
|
||
| if [ "$status" -ge 0 ] ; then |
There was a problem hiding this comment.
Another thought here may be to allow --error to be specified separately allowing the user to have more control over what got written to the various file handles.
There was a problem hiding this comment.
Sorry, but not understood. You can explain better?
There was a problem hiding this comment.
I think I understand, you wrote. But allow --error, in my opinion, allow more mistakes. Because the user can be configured - status 0 and --error at the same time. Does not make sense. My opinion is --output is the best approach
|
|
|
Did you sign the license agreement? |
|
@FCesar I'm going to close this since we are unable to accept changes from folks that haven't signed our Contributor License Agreement. Please let me or @ckstettler know if you change your mind and would like these changes merged |
Hello everybody,
I propose redirect stdout to stderr if status more than 0, in my humble opinion, this behavior make a sense
What do you think about ?