Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #71, where the
rCompare
function would error if a single column dataframe was passed.This was caused by the way R handles filtering dataframes with a single column.
df[1:2, ]
returns a dataframe ifdf
has 2+ columns but returns a vector ifdf
has 1 column.This behaviour can be changed by passing
drop=TRUE
(see https://stackoverflow.com/questions/21025609/how-do-i-extract-a-single-column-from-a-data-frame-as-a-data-frame)Motivation and Context
Fixes #71 reported by an external user
How Has This Been Tested?
matchNoIndex
function because those tests look like they could use a refactor/tidy up anyway - I can go back and do this if needed?Screenshots (if appropriate):
Types of changes
Checklist:
Tests throw existing warnings around
testthat
. Travis isn't happy, but that appears to be due to #76 .