-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
St plots #161
base: master
Are you sure you want to change the base?
St plots #161
Conversation
Update readme for 3.8 update
Updated Depreciated code that will last to at least python 3.10
Update to 3.8 with conda-forge channel and depreciated code fix
Hey @cherman2 @colinvwood I have updated the code to reflect most of the changes asked for. I would appreciate a review of the changes I have made and their use. If they work as planned and as I have tested, I will add an addition to the readme to show the changes with visuals and explanations. The only requested changes I left alone were in reducing code on png file output and in the paired heatmap as I am unsure how to proceed. Let me know what y'all think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andy6a
It looks like the two heatmap vizs and two bar plots might be able to merge into one viz respectively.
There is alot of code duplication still, I tried to add code suggestions as examples for how to address this.
sourcetracker/_plot.py
Outdated
""" | ||
# '#1f77b4'Blue, '#ff7f0e'Orange, '#2ca02c'Green, '#d62728'Red, | ||
# '#9467bd'Purple, '#8c564b'Brown, '#e377c2'Pink, '#7f7f7f'Grey, | ||
'#bcbd22'Gold, '#17becf'Cyan | ||
#make sure to use contrasting colors in order better illuminate | ||
your data above are some example codes to use | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still think this should be removed or moved up to top of method.
ax=axes[i]) | ||
g[i].set_xlabel("") | ||
g[i].set_ylabel("") | ||
g[i].set_yticks([]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you need to address this?
Co-authored-by: Chloe Herman <60228108+cherman2@users.noreply.github.com>
Co-authored-by: Chloe Herman <60228108+cherman2@users.noreply.github.com>
Co-authored-by: Chloe Herman <60228108+cherman2@users.noreply.github.com>
Hi @andy6a, |
Hey @cherman2 could you go over the PR again to confirm which things I still need to work through? I know the colors issue is the biggest issue but I need a refresher on what else needs to be done. |
Hi @andy6a, Here is what I see for the OG heatmap. There is a huge amount of white space around the Heatmap. Also My labels get cut off the left edge of the figure. Otherwise this heatmap is pretty scalable OG Heatmap todo:
Here is what I see for the paired heatmap. There is also a huge amount of white space around the heatmap that should be removed. Another major problem for scalability is the fact the legend is as long as the figure. For a figure as long as mine this means you aren't able to see the whole range of the legend at once. Paired Heatmap todo:
Does all this make sense? Let me know if you have any questions or need data to test this on. |
Hey @cherman2, I made some changes which should solve the white space issues, can you test that out on your data. Also might solve label but honestly thats just hopeful thinking. If you could let me know that would be appreciated. (Also what you asked for makes perfect sense.) |
Hi @andy6a, Here is my command: I think there is two remaining issues:
Sorry for my slow response. This might go faster if you are able to test on your end. Let me know if you need data in order to replicate this. |
Hey @cherman2, Second, that is intentional because the default for heatmap is true whereas the paired heatmap and stacked bar is false. I can change this if you would like but the heatmap as the default output is a feature I inherited. If you and Dr. Caporaso would like to change that we can but we will need to update that in the readme. |
Upgrading plotting function with new plots including Stacked bar and paired heatmap for paired inputs as well as an upgraded heatmap.