Skip to content

Commit

Permalink
Fix a crash do to calling non-existing selector
Browse files Browse the repository at this point in the history
That said, the popover is not moving correctly with the
attached view as it did. Patch in a following commit
  • Loading branch information
Antoine Mercadal committed Apr 10, 2012
1 parent dd63174 commit 1e2964a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion AppKit/_CPAttachedWindow.j
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ var _CPAttachedWindow_attachedWindowShouldClose_ = 1 << 0,
// TODO: don't recompute everything, just compute the move offset
var edge = [_windowView preferredEdge];

[self positionRelativeToView:_targetView preferredEdge:edge];
[self positionRelativeToRect:nil ofView:_targetView preferredEdge:edge];
}
}

Expand Down

1 comment on commit 1e2964a

@aparajita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two issues to deal with:

  • Moving the parent window that contains the attached view. This we can't do correctly until we have true child window support in CPWindow. For now, the only way to do it is to observe WindowDidMoveNotification of the attached view's window.
  • Moving the attached view within its window. In my testing your previous code wasn't working, but I might have broken it somehow.

Please sign in to comment.