Skip to content

Commit

Permalink
Added dump_theme tool
Browse files Browse the repository at this point in the history
  • Loading branch information
@aparajita
aparajita committed Apr 6, 2012
1 parent eb292e6 commit d59bc01
Show file tree
Hide file tree
Showing 4 changed files with 489 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Tools/Jakefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
require("../common.jake");

// nib2cib uses fontinfo and capp uses nib2cib
subtasks(["fontinfo", "nib2cib", "capp", "NativeHost", "XcodeCapp"], ["build"/*, "clean", "clobber"*/]);
subtasks(["fontinfo", "nib2cib", "capp", "dump_theme", "NativeHost", "XcodeCapp"], ["build"/*, "clean", "clobber"*/]);

subtasks(["fontinfo"], ["clean", "clobber"]);
11 changes: 11 additions & 0 deletions Tools/dump_theme/Jakefile
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

require ("../../common.jake");

var FILE = require("file"),
SYSTEM = require("system"),
path = FILE.Path(FILE.join(SYSTEM.prefix, "bin", "dump_theme"));

FILE.copy("dump_theme", path);
path.chmod(0755);

copyManPage("dump_theme", 1);

7 comments on commit d59bc01

@BlairDuncan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without admin rights, this causes the installer to hang waiting for admin password to install the man pages.

@aparajita
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit, thanks for pointing that out.

@BlairDuncan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens in Tools/nib2cib and Tools/capp as well.

@aparajita
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it worked, the error is erroneous.

@BlairDuncan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, when I would do a jake install and I would get the password prompt I could hit return. It prompts 3 times and then carries on. Eventually it would complete.
I just pulled from master.
Now at Tools/nib2cib it completely bails after the 3 time with "Unable to create the man directory." in red.

Oh, it seems that I had made changes to the jake files to get around that and recently replaced them.

Anyways, it would be nice if we had the option to skip these if the user does not have sudo access.

@aparajita
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways, it would be nice if we had the option to skip these if the user does not have sudo access

Fair enough.

@aparajita
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit.

Please sign in to comment.