Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing textFields on different windows can clobber each others contents. [+1] #1983

Closed
BlairDuncan opened this issue Sep 6, 2013 · 4 comments · Fixed by #2010
Closed

Editing textFields on different windows can clobber each others contents. [+1] #1983

BlairDuncan opened this issue Sep 6, 2013 · 4 comments · Fixed by #2010
Labels
Milestone

Comments

@BlairDuncan
Copy link
Contributor

To reproduce as an example I have simply added 2 textFields to the DocumentController Test. Launched the app, hit a command+N to create a 2nd document window.
Clicked into the first textField in document1 and typed a "1"
Clicked into the 2nd textField in document1 and typed a "2"
Clicked into the first textField in document2 and typed a "3"
Clicked into the 2nd textField in document2 and typed a "4"
As seen here:
screen shot 2013-09-06 at 5 29 26 pm

Now click into the first textField in document1
The contents of the 2nd textField in document1 now contains the contents of 2nd textField in document2.
As seen here:
screen shot 2013-09-06 at 5 29 41 pm

@BlairDuncan
Copy link
Contributor Author

Seems to be caused by resignFirstResponder not checking that the input owner is self.

so the fix would be line 695 of CPTextField
if (_isEditing)
should be
if (_isEditing && CPTextFieldInputOwner === self)

@cappbot
Copy link

cappbot commented Oct 17, 2013

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@daboe01
Copy link
Contributor

daboe01 commented Oct 17, 2013

+1

@cappbot
Copy link

cappbot commented Oct 17, 2013

Milestone: Someday. Vote: 1. Label: #new. What's next? A reviewer should examine this issue.

daboe01 added a commit to daboe01/cappuccino that referenced this issue Oct 27, 2013
…s contents

Was be caused by resignFirstResponder not checking that the input owner is self.

Fixes cappuccino#1983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants