Sheets: issue #1106 and -animationResizeTime: fix #1108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e context if the animation is running.
Removed duration arg in _setFrame:delegate:duration:curve because it's already in _CPWindowFrameAnimation init method"
Code cleanup, modified AttachedSheet example to test issue#1106
…Time: default impl. should return 0.2s/150pixels, not 0.2s
|
Thanks martin! We'll get these in after 0.9 :) |
|
Merged, thanks! |
|
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit #1:
Fixes issue #1106.
commit #2:
I think we discussed that before but not sure: for windows and/or sheets, do we want the default animation to have a constant duration (current capp) or a constant speed like in cocoa ?
With this commit, animationResizeTime: returns a duration based on a 0.2s/150 pixels speed.