New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-default JVM #1229
Use non-default JVM #1229
Conversation
default Java VM, and pass this on in narwhal.conf, so that narwhal also uses the bootstrapped Java VM. Users may either set JAVA_HOME in the environment or pass --java-home as a parameter to specify where the Java VM resides. check_build_environment is executed later since its behavior is dependent upon using the correct Java VM. If the Java VM used to bootstrap narwhal is not in the PATH, append JAVA_HOME to narwhal.conf so that narwhal can use this value.
The related patch in Narwhal was pulled in almost a year ago. Is there a reason this was not? |
Label: #new. What's next? A reviewer should examine this issue. |
-tools |
Labels: #needs-confirmation, #new. What's next? This issue needs a volunteer to independently reproduce the issue. |
Can you please repost this patch on a separated branch? It won't merge cleanly as is. |
I updated my branch and cleaned up bootstrap.sh so the diff is now clean. |
This call was used at all times in earlier code, but in the cappuccino master is now restricted to only being called if the OS is Darwin. Updating my branch to reflect that.
-#new |
Milestone: Someday. Labels: #needs-confirmation, #needs-review, tools. What's next?
|
I'm going to mark this as #wont-fix because switching to node will eliminate the need for any JVM. #wont-fix |
Milestone: Someday. Labels: #wont-fix, tools. What's next? A reviewer or core team member has decided against acting upon this issue. |
Allow the JVM to be specified when bootstrapping narwhal, using either a command line option or the
--java-home parameter to specify where the Java VM resides.
This patch executes check_build_environment later since its behavior is dependent upon using the correct
JVM. If the Java VM used to bootstrap narwhal is not in the PATH, append JAVA_HOME to narwhal.conf so that narwhal can use this value.
This patch depends on a patch for narwhal (280north/narwhal#23).