Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-default JVM #1229

Closed
wants to merge 3 commits into from
Closed

Use non-default JVM #1229

wants to merge 3 commits into from

Conversation

rhwood
Copy link

@rhwood rhwood commented Apr 14, 2011

Allow the JVM to be specified when bootstrapping narwhal, using either a command line option or the
--java-home parameter to specify where the Java VM resides.

This patch executes check_build_environment later since its behavior is dependent upon using the correct
JVM. If the Java VM used to bootstrap narwhal is not in the PATH, append JAVA_HOME to narwhal.conf so that narwhal can use this value.

This patch depends on a patch for narwhal (280north/narwhal#23).

default Java VM, and pass this on in narwhal.conf,
so that narwhal also uses the bootstrapped Java
VM.

Users may either set JAVA_HOME in the environment
or pass --java-home as a parameter to specify
where the Java VM resides.

check_build_environment is executed later since
its behavior is dependent upon using the correct
Java VM.

If the Java VM used to bootstrap narwhal is not
in the PATH, append JAVA_HOME to narwhal.conf
so that narwhal can use this value.
@rhwood
Copy link
Author

rhwood commented Apr 18, 2012

The related patch in Narwhal was pulled in almost a year ago. Is there a reason this was not?

@cappbot
Copy link

cappbot commented May 9, 2012

Label: #new. What's next? A reviewer should examine this issue.

@ggsato
Copy link
Contributor

ggsato commented May 24, 2012

-tools
+#needs-confirmation

@cappbot
Copy link

cappbot commented May 24, 2012

Labels: #needs-confirmation, #new. What's next? This issue needs a volunteer to independently reproduce the issue.

@primalmotion
Copy link
Member

Can you please repost this patch on a separated branch? It won't merge cleanly as is.

@rhwood
Copy link
Author

rhwood commented Jul 2, 2012

I updated my branch and cleaned up bootstrap.sh so the diff is now clean.

This call was used at all times in earlier code, but in the cappuccino
master is now restricted to only being called if the OS is Darwin.
Updating my branch to reflect that.
@ahankinson
Copy link
Contributor

-#new
+#needs-review
+tools
milestone=Someday

@cappbot
Copy link

cappbot commented Feb 15, 2013

Milestone: Someday. Labels: #needs-confirmation, #needs-review, tools. What's next?

  • This issue needs a volunteer to independently reproduce the issue.
  • This issue is pending an architectural or implementation design decision and should be discussed or voted on.

@aparajita
Copy link
Contributor

I'm going to mark this as #wont-fix because switching to node will eliminate the need for any JVM.

#wont-fix

@cappbot
Copy link

cappbot commented Feb 16, 2013

Milestone: Someday. Labels: #wont-fix, tools. What's next? A reviewer or core team member has decided against acting upon this issue.

@cappbot cappbot closed this Feb 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants