Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for menu selection that was broken with the change to CPEvent timestamp #1513

Merged
merged 6 commits into from
Jun 15, 2012

Conversation

BlairDuncan
Copy link
Contributor

fix for this commit :
5763ebd
that broke menu selection

@cappbot
Copy link

cappbot commented May 9, 2012

Labels: #accepted, #needs-improvement, AppKit, bug. What's next? The code for this issue has problems with formatting or fails a capp_lint check, has bugs, or has non-optimal logic or algorithms. It should be improved upon.

@BlairDuncan
Copy link
Contributor Author

What still needs to be done to this? The missing periodic timestamp was added a month ago.

@BlairDuncan
Copy link
Contributor Author

I just updated this with a few more fixes.
In cocoa when a menu is active, moving the mouse off the menu should remove highlite from items.
To reproduce:
Activate a menu and move mouse over an item to highlite it
Move mouse out of menu and the highlite should be removed.
With the mouse still off the menu, cursor up or down and menu items should be highlited and any mouse moves outside the menu should not change highlite.

primalmotion added a commit that referenced this pull request Jun 15, 2012
Fix for menu selection that was broken with the change to CPEvent timestamp
@primalmotion primalmotion merged commit 0d29f15 into cappuccino:master Jun 15, 2012
@primalmotion
Copy link
Member

merged. Thanks.

#fixed

@cappbot
Copy link

cappbot commented Jun 15, 2012

Labels: #fixed, AppKit, bug. What's next? This issue is considered successfully resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants