Added a themed attribute for round rect selection of rows. [+1]

[mrcarlberg]

Selections in the tableview can now have round corners. The default is a regular
rect, but if the selection radius is changed. Nice good looking round rect
selections will appear.

[cappbot]

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

[primalmotion]

Can you post a screenshot of the result?

As this is not part of Cocoa (AFAIK), we need a vote here.

+AppKit
#needs-review

[cappbot]

Milestone: Someday. Labels: #needs-review, #new, AppKit. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

[mrcarlberg]

Here is a link to a small screen dump of an outline view. http://mini.carlberg.org/roundrect.png
As you can see the selection rect is a round rect with corner radius of 5 pixels. This makes it possible to get a very nice proffessional look on text views.

[mrcarlberg]

Ahh, I can include the screen dump in the comment!!!!

As I said above, the selection rect is a round rect with corner radius of 5 pixels. This makes it possible to get a very nice proffessional look on text views.

[aljungberg]

I guess there is no Cocoa equivalent for this. When we merge in the new view based CPTableView this kind of customisation becomes a lot easier. Even then I guess a theme attribute is not a bad idea as it's a handy way to accomplish something without creating a custom row view.

[primalmotion]

I personally don't like the look, but as it's a theme attribute, I think it doesn't hurt anything and it's good to enhance the theming capabilities.

My only concern is the two methods added to CPTableView (selectionHighlightRadius and setSelectionHighlightRadius:). Do we really need them as It adds some non Cocoa API? I think the rounded selection should only be in the theme descriptors. And if the user doesn't want to create a new theme (who wants? :)), he can just call [myTable setValue:3 forThemeAttribute:@"selection-radius"];

[aljungberg]

Yeah that might be better since it's non standard API and again will be less relevant with the future view based table view.

[primalmotion]

@mrcarlberg if you remove the selectionHighlightRadius APi from table view, for me it's
+1

[cappbot]

Milestone: Someday. Vote: 1. Labels: #needs-review, #new, AppKit. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

[primalmotion]

Merged, Thanks!