Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key loop fix #1577

Merged
merged 1 commit into from
Jun 28, 2012
Merged

Key loop fix #1577

merged 1 commit into from
Jun 28, 2012

Conversation

aparajita
Copy link
Contributor

Fixed two key loop bugs:

  1. If an initial first responder was set before the window became the key window, the key loop would not be calculated.
  2. The key loop was not being calculated correctly because the allViews function was duplicating all of the views.

Also made a small optimization, there is no reason not to use _initialFirstResponder instead of [self initialFirstResponder] as far as I can tell.

aparajita pushed a commit that referenced this pull request Jun 28, 2012
Merge pull request #1577 from slevenbits/key-loop-fix
d923fb5 
Key loop fix
@aparajita aparajita merged commit d923fb5 into cappuccino:master Jun 28, 2012
@cappbot
Copy link

cappbot commented Jun 28, 2012

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
#new
Projects
None yet
Milestone
Someday
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aparajita @cappbot