Fixed: CPDatePicker does not grey out dates outside of minDate and maxDate #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Nice one. It's great when such a nice feature takes so little code. :) -#new |
|
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
|
Milestone: 0.9.8. Labels: #needs-review, AppKit, feature. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on. |
primalmotion
added a commit
that referenced
this pull request
Jan 15, 2015
Fixed: CPDatePicker does not grey out dates outside of minDate and maxDate
|
+#fixed Thanks |
|
Milestone: 0.9.8. Labels: #fixed, AppKit, feature. What's next? This issue is considered successfully resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CPDatePicker did not disable the dates outside of minDate and maxDate. This left the user wondering why some dates are not clickable for no apparent reason.
This PR sets the state to disabled if the tile not within minDate and maxDate.
Fixes #2262