Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenStack Heat template for deploying single-instance CapRover #2069

Merged
merged 1 commit into from
May 27, 2024

Conversation

panasenco
Copy link
Contributor

The goal is to allow CapRover users to be able to easily deploy on any OpenStack cloud, including Infomaniak, SharkTech, VEXXHOST, OVHcloud, and many others.

This PR is for the heat template file to deploy single-instance CapRover.

Slack thread: https://caprover.slack.com/archives/CKQSNHT32/p1716761306596949

Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a couple of minor comments.

echo "Installing Docker with commands copied from https://docs.docker.com/engine/install/ubuntu/"
# Add Docker's official GPG key:
apt-get update
apt-get install ca-certificates curl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Openstack, but in a typical setup, this requires user's input (Y to continue). Does openstack automagically bypass this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated with -y. This slipped past my radar because the packages were small enough to not prompt for approval.

@@ -0,0 +1,91 @@
heat_template_version: 2018-08-31
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the file to dev-scripts directory? setup is a new directory and it'll add clutter to the root of the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! Done.

@githubsaturn githubsaturn merged commit a563cd0 into caprover:master May 27, 2024
3 checks passed
@githubsaturn
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants