-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Rocket.Chat one-click template #579
[NEW] Rocket.Chat one-click template #579
Conversation
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Looks great, excited to have Rocket Chat here! Thanks! |
Thank you so much for this, @debdutdeb ! |
@debdutdeb nice work! The initial user is created with a username and password. This allows for logging in. However, when accessing the user profile ( I am not entirely sure if this can be resolved by adding the |
Hey @GoaGit can you please open an issue on https://github.com/rocketchat/rocket.chat ? |
Hey, I opened issue #736 regarding a limitation of the regex that enforces version >= 5.0.4. |
@debdutdeb I also believe that this app is problematic to update as a one-click-app without loosing data. Please tell me if I am wrong, but following caprover documentation:
I am tinkering from the original yml file to deploy a new one-click version from the TEMPLATE app while conserving the previous db app and its data, but no success so far... any idea? |
Hi @Ziip-dev Can you please send me the caprover doc you mentioned? |
Thank you for your answer, and sorry for pinging in the first place :)
That is this one. Well, from my understanding of that documentation, the caproverExtra section adds options that cannot be replicated in the deployment of a docker image. But as this is only an option in the caprover dashboard I guess you are right and that should work out of the box. However, when I first tried this (deployment of image 5.1.3 via method 6) the build succeeded but my server became unaccessible (nginx 502 I believe). Reverting to the previous image didn't help either, that's why I started tinkering to deploy only a rocket.chat app that would reuse the existing db. |
Did you check rocketchat logs (when you got the 502)? Can you share that here please? |
Yep, somewhat it could not connect to the db container despite using the exact same environment variables. I suspected a docker network discrepancy but could not figure it out. Details on what I have tried: The modified rocketchat.yml file that I threw in a one-click-app template
The current app's logs (error due to lack of memory, different from yesterday)
The db container's logs
PS: another deployment of rocketchat app made me notice heavy load on my server caused by several |
New deployment attempt of rocket.chat 5.1.4 today. Still a strange error related to JS out of memory... Any idea?
Nothing very significant to me... I am really not familiar with JS ecosystem and changing node memory settings seems not to be a reliable solution. |
@debdutdeb I think there is an issue with the deployment of newer versions (not certain that it is not a problem on my side only though).
```
2022-10-04T08:28:46.866155111Z <--- JS stacktrace --->
2022-10-04T08:28:46.866158761Z
2022-10-04T08:28:46.866162101Z FATAL ERROR: MarkCompactCollector: young object promotion failed Allocation failed - JavaScript heap out of memory
2022-10-04T08:28:46.866165711Z 1: 0xa3aaf0 node::Abort() [node]
2022-10-04T08:28:46.866169101Z 2: 0x970199 node::FatalError(char const*, char const*) [node]
2022-10-04T08:28:46.866172551Z 3: 0xbba42e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
2022-10-04T08:28:46.866176031Z 4: 0xbba7a7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
2022-10-04T08:28:46.866179641Z 5: 0xd769c5 [node]
2022-10-04T08:28:46.866182951Z 6: 0xda735e v8::internal::EvacuateNewSpaceVisitor::Visit(v8::internal::HeapObject, int) [node]
2022-10-04T08:28:46.866186341Z 7: 0xdb3396 v8::internal::FullEvacuator::RawEvacuatePage(v8::internal::MemoryChunk*, long*) [node]
2022-10-04T08:28:46.866189821Z 8: 0xd9f52f v8::internal::Evacuator::EvacuatePage(v8::internal::MemoryChunk*) [node]
2022-10-04T08:28:46.866207741Z 9: 0xd9f7a8 v8::internal::PageEvacuationTask::RunInParallel(v8::internal::ItemParallelJob::Task::Runner) [node]
2022-10-04T08:28:46.866211481Z 10: 0xd92089 v8::internal::ItemParallelJob::Run() [node]
2022-10-04T08:28:46.866215301Z 11: 0xdb52f0 void v8::internal::MarkCompactCollectorBase::CreateAndExecuteEvacuationTasks(v8::internal::MarkCompactCollector*, v8::internal::ItemParallelJob*, v8::internal::MigrationObserver*, long) [node]
2022-10-04T08:28:46.866229631Z 12: 0xdb5b8c v8::internal::MarkCompactCollector::EvacuatePagesInParallel() [node]
2022-10-04T08:28:46.866233221Z 13: 0xdb5d55 v8::internal::MarkCompactCollector::Evacuate() [node]
2022-10-04T08:28:46.866236441Z 14: 0xdc7d51 v8::internal::MarkCompactCollector::CollectGarbage() [node]
2022-10-04T08:28:46.866239611Z 15: 0xd84018 v8::internal::Heap::MarkCompact() [node]
2022-10-04T08:28:46.866246081Z 16: 0xd85b08 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
2022-10-04T08:28:46.866249651Z 17: 0xd88f4c v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [node]
2022-10-04T08:28:46.866253091Z 18: 0xd5762b v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [node]
2022-10-04T08:28:46.866256431Z 19: 0x109fbef v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [node]
2022-10-04T08:28:46.866259701Z 20: 0x1448df9 [node]
2022-10-04T08:29:53.541270021Z strict mode: use allowUnionTypes to allow union type keyword at "#/properties/value" (strictTypes)
```
I then went to deploy the original rocket.chat 5.0.4 one click app without changing the version number and that works again. |
Try adding this environment variable, |
* initial commit * Working Rocket.Chat template Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat> * Add Rocket.Chat logo Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat> * fix formatting & fix real name var regex Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
☑️ Self Check before Merge
Closes #66