Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC tooling updates #1651

Merged
merged 6 commits into from
Mar 7, 2021
Merged

MSVC tooling updates #1651

merged 6 commits into from
Mar 7, 2021

Conversation

hmoenck
Copy link

@hmoenck hmoenck commented Jun 30, 2020

Resolved some issues when building with MSVC:

  • PlatformToolset always defaulted to Visual Studio 10 (v100), regardless of used version. I made the property sheet to fix this optional, so it is less intrusive to other developers.
  • Some implicit casts caused warnings
  • test_basic does not exist (?) but was referenced in the solution

@pranith
Copy link
Contributor

pranith commented Mar 4, 2021

Can you please create a new PR on libcapstone?

@tmfink
Copy link
Contributor

tmfink commented Mar 4, 2021

@pranith instead of asking folks to make duplicate pull requests to your fork, you can wait until the changes are merged into this repo. Once the pull requests get merged, you can just merge/cherry-pick the changes into your fork.

That is half the work for the submitters and generates fewer notifications for those who follow development of this repo. 😃

@pranith
Copy link
Contributor

pranith commented Mar 4, 2021

@tmfink The reason I ask is because there are PRs that are more than 6 months old. It might be better to continue development on the fork. But I heard back from @aquynh today. Let's see how it turns out.

@aquynh aquynh merged commit c59d62f into capstone-engine:master Mar 7, 2021
@aquynh
Copy link
Collaborator

aquynh commented Mar 7, 2021

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants