Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64 SYS instruction operands #1859

Merged

Conversation

adamjseitz
Copy link
Contributor

This PR fixes issues outlined in #1856.

  • Populate the skipped ARM64_OP_SYS type operands into the operands array
  • Use a single enum type for all sys type operands - resolves inconsistencies between C and bindings and among the different operand types (see the issue for more details)

Please note that I believe that this is a breaking API change due to reworking the SYS operand enums.

@adamjseitz
Copy link
Contributor Author

I've added a test under suite/regress, modeled after the one added in #1840, but I could not find where these run in the GitHub Actions configuration, if at all, so I am concerned that these regression tests might not actually be running.

Let me know if there is a better place to be putting these sorts of tests, or if I should investigate adding these to the GitHub Actions configuration.

@kabeor
Copy link
Member

kabeor commented Mar 22, 2022

@adamjseitz adamjseitz force-pushed the aarch64-sys-instruction-operands branch 3 times, most recently from ce1ddeb to 1fd1584 Compare March 22, 2022 12:47
@adamjseitz adamjseitz force-pushed the aarch64-sys-instruction-operands branch from 1fd1584 to 1d9ea9c Compare March 22, 2022 13:32
@kabeor
Copy link
Member

kabeor commented Mar 22, 2022

Really cool, thx!

@kabeor kabeor merged commit 7229023 into capstone-engine:next Mar 22, 2022
@adamjseitz adamjseitz deleted the aarch64-sys-instruction-operands branch March 22, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants