Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Error trait #142

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Implement Error trait #142

merged 4 commits into from
Jul 17, 2023

Conversation

tmfink
Copy link
Member

@tmfink tmfink commented Jul 16, 2023

Fixes #141

Introduces a breaking change with the std feature

@tmfink tmfink self-assigned this Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #142 (1160765) into master (8c17287) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 1160765 differs from pull request most recent head 18c1aab. Consider uploading reports for the commit 18c1aab to get more accurate results

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   93.98%   93.96%   -0.03%     
==========================================
  Files          21       22       +1     
  Lines        2678     2733      +55     
  Branches     2637     2687      +50     
==========================================
+ Hits         2517     2568      +51     
- Misses        161      165       +4     
Impacted Files Coverage Δ
capstone-rs/src/arch/mod.rs 92.79% <ø> (+1.04%) ⬆️
capstone-rs/src/error.rs 59.52% <ø> (ø)
capstone-rs/src/ffi.rs 100.00% <ø> (ø)
capstone-rs/src/lib.rs 100.00% <ø> (ø)
capstone-rs/src/capstone.rs 92.36% <100.00%> (-1.93%) ⬇️
capstone-rs/src/instruction.rs 92.50% <100.00%> (-1.42%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tmfink tmfink force-pushed the std-error branch 2 times, most recently from cc8901e to c49eeb8 Compare July 17, 2023 02:17
@tmfink tmfink merged commit 74ccb09 into capstone-rust:master Jul 17, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement std::error::Error for capstone::Error
1 participant