Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Capstone 4.0 WIP #60

Merged
merged 20 commits into from Apr 2, 2019
Merged

Support Capstone 4.0 WIP #60

merged 20 commits into from Apr 2, 2019

Conversation

tmfink
Copy link
Member

@tmfink tmfink commented Feb 26, 2019

Support Capstone 4.0; handle issue #52

@tmfink tmfink self-assigned this Feb 26, 2019
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #60 into master will increase coverage by 73.44%.
The diff coverage is 93.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #60       +/-   ##
===========================================
+ Coverage   21.08%   94.52%   +73.44%     
===========================================
  Files          80       18       -62     
  Lines       29617     4438    -25179     
===========================================
- Hits         6244     4195     -2049     
+ Misses      23373      243    -23130
Impacted Files Coverage Δ
capstone-rs/src/arch/x86.rs 99.11% <100%> (-0.2%) ⬇️
capstone-rs/src/arch/mod.rs 93.98% <100%> (+1.05%) ⬆️
capstone-rs/src/instruction.rs 85.59% <100%> (-2.7%) ⬇️
capstone-rs/src/capstone.rs 95.47% <100%> (+1.64%) ⬆️
capstone-rs/src/error.rs 76.66% <33.33%> (+8.24%) ⬆️
capstone-rs/src/constants.rs 79.34% <77.41%> (+15.28%) ⬆️
capstone-rs/src/arch/evm.rs 88.46% <88.46%> (ø)
capstone-rs/src/arch/m68k.rs 91.11% <91.11%> (ø)
capstone-rs/src/arch/tms320c64x.rs 91.89% <91.89%> (ø)
capstone-rs/src/arch/m680x.rs 95.75% <95.75%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5044ace...e387834. Read the comment docs.

@tmfink
Copy link
Member Author

tmfink commented Apr 2, 2019

Even though the i686-pc-windows-gnu and x86_64-pc-windows-gnu tests are failing on AppVeyor, I believe this is a problem with the AppVeyor config.

On Ubuntu 18.04, I was able to build/test for the x86_64-pc-windows-gnu target by:

  1. Installing toolchain/wine: apt-get install g++-mingw-w64-x86-64 wine
  2. Setting ~/.cargo/config:
    [target.x86_64-pc-windows-gnu]
    linker = "x86_64-w64-mingw32-gcc"
    ar = "x86_64-w64-mingw32-gcc-ar"
  3. Build test binaries:
    cargo test --target=x86_64-pc-windows-gnu
        Finished dev [unoptimized + debuginfo] target(s) in 0.12s
         Running target/x86_64-pc-windows-gnu/debug/deps/capstone-e3abe0e98ae3c2a7.exe
    run-detectors: unable to find an interpreter for target/x86_64-pc-windows-gnu/debug/deps/capstone-e3abe0e98ae3c2a7.exe
    error: test failed, to rerun pass '-p capstone --lib'
    
  4. Run with wine:
    wine target/x86_64-pc-windows-gnu/debug/deps/capstone-e3abe0e98ae3c2a7.exe
    

@tmfink tmfink merged commit 4e1520c into master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant