Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Empty string check for post title #54

Closed
steverogers180 opened this issue Sep 1, 2021 · 2 comments
Closed

[Feature] Empty string check for post title #54

steverogers180 opened this issue Sep 1, 2021 · 2 comments
Assignees
@jackdishman
Labels
bug Something isn't working enhancement New feature or request

Comments

@steverogers180
Copy link
Contributor

@steverogers180 steverogers180 added this to the Demo milestone Sep 1, 2021
@steverogers180 steverogers180 added the bug Something isn't working label Sep 1, 2021
@nadimkobeissi
Copy link
Contributor

Note that we've decided to remove subtitles entirely.

@chrispanag
Copy link
Contributor

Titles are now checked for empty string in the content-validation branch of capsule-orbit. The same check must be implemented on capsule-vue too.

Subtitles are optional, so when they are removed from capsule-vue, I'll remove them from capsule-orbit too.

@chrispanag chrispanag changed the title Need to add empty string check for post title and post subtitle Need to add empty string check for post title Sep 3, 2021
@chrispanag chrispanag added the enhancement New feature or request label Sep 3, 2021
@chrispanag chrispanag changed the title Need to add empty string check for post title [Feature] Empty string check for post title Sep 3, 2021
chrispanag added a commit that referenced this issue Sep 3, 2021
@chrispanag
[Feature] Trim strings and disallow empty title - Fixes #54
e6910ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackdishman jackdishman

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nadimkobeissi @jackdishman @chrispanag @steverogers180