Handle case where no arguments are passed to a buffer assignment

captbaritone · May 6, 2020 · 568448c · 568448c
1 parent 94f6305
commit 568448c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/packages/compiler/fixtures/errors/assign_to_buffer_zero_args.eel b/packages/compiler/fixtures/errors/assign_to_buffer_zero_args.eel
@@ -0,0 +1 @@
+megabuf() = 10;
diff --git a/packages/compiler/src/__tests__/__snapshots__/errorsUtils.test.ts.snap b/packages/compiler/src/__tests__/__snapshots__/errorsUtils.test.ts.snap
@@ -16,6 +16,14 @@ exports[`assign_to_buffer_too_many_args.eel 2`] = `
     |            ^"
 `;
 
+exports[`assign_to_buffer_zero_args.eel 1`] = `"Expected 1 argument when assinging to a buffer but got 0."`;
+
+exports[`assign_to_buffer_zero_args.eel 2`] = `
+"
+> 1 | megabuf() = 10;
+    | ^^^^^^^^^"
+`;
+
 exports[`assign_to_non_buff_function_call.eel 1`] = `"The only function calls which may be assigned to are \`gmegabuf()\` and \`megabuf()\`."`;
 
 exports[`assign_to_non_buff_function_call.eel 2`] = `

diff --git a/packages/compiler/src/emitter.ts b/packages/compiler/src/emitter.ts
@@ -327,10 +327,10 @@ export function emit(ast: Ast, context: CompilerContext): number[] {
       if (ast.left.type == "CALL_EXPRESSION") {
         const localIndex = context.resolveLocalF64();
         const { operator, left } = ast;
-        if (ast.left.arguments.length !== 1) {
+        if (left.arguments.length !== 1) {
           throw createUserError(
-            `Expected 1 argument when assinging to a buffer but got ${ast.left.arguments.length}.`,
-            ast.left.arguments[1].loc,
+            `Expected 1 argument when assinging to a buffer but got ${left.arguments.length}.`,
+            left.arguments.length === 0 ? left.loc : left.arguments[1].loc,
             context.rawSource
           );
         }
@@ -347,7 +347,7 @@ export function emit(ast: Ast, context: CompilerContext): number[] {
         const addOffset = emitAddMemoryOffset(bufferName);
 
         const index = [
-          ...emit(ast.left.arguments[0], context),
+          ...emit(left.arguments[0], context),
           op.local_tee,
           ...unsignedLEB128(localIndex),
           op.i32_trunc_s_f64,