Convert null MAKI objects to global NULL value (#866)

* Coerce null MAKI objects to 0 * use global NULL value
captbaritone · Nov 30, 2019 · 0297eb7 · 0297eb7
1 parent e586479
commit 0297eb7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/modern/src/maki-interpreter/interpreter.js b/modern/src/maki-interpreter/interpreter.js
@@ -161,11 +161,17 @@ export function* interpret(start, program, stack = []) {
         }
         const obj = popStackValue();
         const ret = obj[methodName](...methodArgs);
+        let value;
         if (isPromise(ret)) {
-          stack.push(yield ret);
+          value = yield ret;
         } else {
-          stack.push(ret);
+          value = ret;
         }
+        if (value === null) {
+          // variables[1] holds global NULL value
+          value = variables[1];
+        }
+        stack.push(value);
         break;
       }
       // callGlobal

diff --git a/modern/src/maki-interpreter/variable.js b/modern/src/maki-interpreter/variable.js
@@ -17,7 +17,7 @@ class Variable {
     if (this._unsubscribeFromValue != null) {
       this._unsubscribeFromValue();
     }
-    if (this.global && this.typeName === "OBJECT" && value !== null) {
+    if (this.global && this.typeName === "OBJECT" && value !== 0) {
       this._unsubscribeFromValue = value.js_listenToAll(
         (eventName, ...args) => {
           this._emitter.trigger(eventName.toLowerCase(), ...args);