Convert null MAKI objects to global NULL value #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think one of the variable registers (1?)holds a magic Singleton “null” value. Can we use that? |
I'm not sure. What I end up seeing in the interpreter is NULL looking like an Int with value of 0 |
|
Yeah, I think that’s right, but I believe there is a variable that always holds the canonical zero value that represents null. |
|
should I test for javascript |
jberg
force-pushed
the
coerce-null-maki-objects
branch
from
4cd20d6
to
d7393af
Compare
|
Well, thats what I did and seems to work well |
jberg
changed the title
captbaritone
pushed a commit
that referenced
this pull request
Nov 30, 2019
* Coerce null MAKI objects to 0 * use global NULL value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to add a test for this, but NULL in MAKI ends up just being 0, so need to coerce object value when comparing value