Make capy fully use the correct platform dependent calling convention #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first step towards making capy abi aware capy-language#35
Simplified Abi for comptime
|
I think it's best to close #35 too and open an issue for the second problem discussed in the issue. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main negative of this is that you now need to add the abi of targets if you want to support them.
I'm marking this as a draft, because there are 2 issues
it currently only works on linux, and the github test runner reports aren't enough for me to find the issuestack_addrinstructions in places where only one is needed, this may be caused by changes i did to theMemoryLocstruct