Fix PDB implementation #425
Conversation
| @@ -90,7 +89,7 @@ func (c *controller) deployPodDisruptionBudget(ctx context.Context, pdb *PodDisr | |||
| pdbCfg.WithLabels(pdb.Labels) | |||
| pdbCfg.WithSpec(pdbSpec) | |||
|
|
|||
| _, err = c.policyClient.PodDisruptionBudgets(pdb.Namespace).Apply(ctx, pdbCfg, metav1.ApplyOptions{}) | |||
| _, err = c.policyClient.PodDisruptionBudgets(pdb.Namespace).Apply(ctx, pdbCfg, metav1.ApplyOptions{FieldManager: "application/apply-patch"}) | |||
There was a problem hiding this comment.
Missed this in the previous PR. But what's the reason for using Apply instead of Create? https://github.com/kubernetes/client-go/blob/v0.27.3/kubernetes/typed/policy/v1/poddisruptionbudget.go#L118
There was a problem hiding this comment.
So we can use Apply for both Undeploy and Redeploy. Otherwise, we need to implement a function that call Update.
There was a problem hiding this comment.
So we can use Apply for both Undeploy and Redeploy
Do you mean for both Deploy and Redeploy?
There was a problem hiding this comment.
Oops, yes, you're right. It's for Deploy and Redeploy.
There was a problem hiding this comment.
Thanks for the fix, @ariefrahmansyah ! I imagine we will be adding it to caraml-dev/turing#346 too.
LGTM.
What this PR does / why we need it:
FieldManager: "application/apply-patch"PatchOptions.meta.k8s.io \"\" is invalid: fieldManager: Required value: is required for apply patch kubernetes/client-go#1036 (comment)Which issue(s) this PR fixes:
Fixes PDB implementation
Does this PR introduce a user-facing change?:
Checklist