fix: Miscellaneous bug fixes for MLflow client upgrade #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
requested review from
ariefrahmansyah,
leonlnj,
deadlycoconuts and
tkpd-hafizhan
ariefrahmansyah
approved these changes
Nov 9, 2023
|
Thanks for the quick review, @ariefrahmansyah ! Merging this. Will also cherry pick this onto a branch from |
krithika369
added a commit
that referenced
this pull request
Nov 9, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> **What this PR does / why we need it**: <!-- Explain here the context and why you're making the change. What is the problem you're trying to solve. ---> This PR contains miscellaneous bug fixes, following #465 **Which issue(s) this PR fixes**: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> 1. Correcting the `protobuf` version range that the SDK can work with 2. Updating Pyfunc user docs to elaborate on the Protobuf compatibility 3. Correcting the `sed` command for fixing the `mlflow` dependency in the conda env file (example test below)  **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Update protobuf dependency range and docs ``` **Checklist** - [ ] Added unit test, integration, and/or e2e tests - [x] Tested locally - [x] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduce API changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains miscellaneous bug fixes, following #465
Which issue(s) this PR fixes:
protobufversion range that the SDK can work withsedcommand for fixing themlflowdependency in the conda env file (example test below)Does this PR introduce a user-facing change?:
Checklist