Add DB connection configs #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
approved these changes
Jan 31, 2023
shydefoo
added a commit
that referenced
this pull request
Feb 1, 2023
* upstream/main: Add DB connection configs (#312)
shydefoo
added a commit
that referenced
this pull request
Feb 3, 2023
* Add DB connection config * Apply SQL connection defaults * Update chart * Remove default config --------- Co-authored-by: Krithika Sundararajan <krithika.sundararajan@go-jek.com>
shydefoo
added a commit
that referenced
this pull request
Feb 3, 2023
* upstream/main: Add DB connection configs (#312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the changes introduced in Merlin (caraml-dev/merlin#307) to avoid intermittent "broken pipe" errors on outgoing connections to the database. This is done by forcefully closing idle connections to the DB through the following configs (all defaults are 0):
The values can be overridden at deploy time, if needed.