Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional DB connection properties #86

Merged
merged 3 commits into from
May 24, 2023
Merged

Add additional DB connection properties #86

merged 3 commits into from
May 24, 2023

Conversation

krithika369
Copy link
Collaborator

@krithika369 krithika369 commented May 24, 2023 •
edited
Loading

This PR adds some additional DB connection configs to avoid intermittent "broken pipe" errors. Similar PRs in other repos:

All defaults are 0:

  connMaxIdleTime: 0s
  connMaxLifetime: 0s
  maxIdleConns: 0
  maxOpenConns: 0

@krithika369 krithika369 marked this pull request as draft May 24, 2023 02:49
@krithika369 krithika369 marked this pull request as ready for review May 24, 2023 03:24
ariefrahmansyah
ariefrahmansyah approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks, krithika

@krithika369 krithika369 merged commit f6948ba into main May 24, 2023
7 of 8 checks passed
@krithika369 krithika369 deleted the add_db_conn_settings branch May 24, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariefrahmansyah ariefrahmansyah ariefrahmansyah approved these changes

@deadlycoconuts deadlycoconuts Awaiting requested review from deadlycoconuts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krithika369 @ariefrahmansyah