Update caraml-auth-google version #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
approved these changes
Mar 13, 2023
krithika369
reviewed
Mar 13, 2023
| caraml-auth-google==0.0.0.post3 |
There was a problem hiding this comment.
Just realised we have google-auth>=2.16.2 dependency here. Isn't it handled by caraml-auth-google ? Can we remove the Google auth dependency from this file?
There was a problem hiding this comment.
Good point, removing it then! Thanks!
|
Thanks a lot for the quick review! Will be merging this once the pipeline succeeds! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The new version of the Turing SDK which incorporates changes to authenticate the user with OpenID Connect tokens did not manage to be pushed successfully to the PyPI repository because it was using a Git dependency on
caraml-auth-google, which Git dependencies are not allowed by PyPI.Since then,
caraml-auth-googlehas been finally released directly to PyPI, paving way for the Turing SDK to update its dependency on it to utilise the released version directly. This PR updates that version directly in therequirements.txtfile.