-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use miniforge conda as Pyfunc ensembler service base image #360
Use miniforge conda as Pyfunc ensembler service base image #360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe yes, unfortunately, as the usage of these images is in our internal DS clusters. |
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> **What this PR does / why we need it**: <!-- Explain here the context and why you're making the change. What is the problem you're trying to solve. ---> Anaconda repo is no longer free for use, for companies with over 200 employees: https://community.anaconda.cloud/t/is-conda-cli-free-for-use/14303 This PR replaces `continuumio/miniconda3` used as the Python SDK docs base image with an image that uses [Miniforge](https://github.com/conda-forge/miniforge). With Miniforge: > [conda-forge](https://conda-forge.org/) set as the default (and only) channel Related PR on Turing: caraml-dev/turing#360 Additionally, the existing references to `miniforge/conda` are updated to the latest version. **Which issue(s) this PR fixes**: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> None **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Upgrade the miniforge/conda version used in Pyfunc models' base Docker image. ``` **Checklist** - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [x] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduce API changes
Anaconda repo is no longer free for use, for companies with over 200 employees: https://community.anaconda.cloud/t/is-conda-cli-free-for-use/14303
This PR replaces
continuumio/miniconda3
used as the Pyfunc ensembler service base image with an image that uses Miniforge. With Miniforge:Additionally, the Miniforge conda version in the batch ensembler base image is updated to the latest as well.