Refactor Message Queue implementation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
changed the title
terryyylim
force-pushed
the
refactor-message-queue-interface
branch
2 times, most recently
from
7f0dd69
to
27e1046
Compare
terryyylim
force-pushed
the
refactor-message-queue-interface
branch
2 times, most recently
from
bea2dba
to
2b32952
Compare
terryyylim
force-pushed
the
refactor-message-queue-interface
branch
2 times, most recently
from
45df65e
to
f77764b
Compare
terryyylim
force-pushed
the
refactor-message-queue-interface
branch
from
f77764b
to
4bd1afa
Compare
terryyylim
force-pushed
the
refactor-message-queue-interface
branch
from
7d94a37
to
468dad8
Compare
terryyylim
changed the title
krithika369
reviewed
Mar 3, 2023
There was a problem hiding this comment.
Thanks for this refactoring @terryyylim ! The PR largely looks good. Left some comments on the organization of the code.
deadlycoconuts
approved these changes
Mar 3, 2023
terryyylim
force-pushed
the
refactor-message-queue-interface
branch
2 times, most recently
from
eab9be0
to
d79b24e
Compare
terryyylim
force-pushed
the
refactor-message-queue-interface
branch
from
d79b24e
to
9fcc4db
Compare
krithika369
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order for Management and Treatment Service to start without an actual Google PubSub, we need to remove the dependency on it, and this PR introduces a generic
MessageQueueinterface for doing so.In addition, an enum has been introduced for the schema used by Treatment Service plugin, to support
noopandpubsubmessage queue kinds.Which issue(s) this PR fixes:
Fixes #