Support multi-stage builds for Management & Treatment Services Dockerfile #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
reviewed
Mar 7, 2023
Dockerfile
Outdated
| @@ -21,6 +21,8 @@ RUN addgroup -S ${XP_USER_GROUP} \ | |||
|
|
|||
| COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/bin/* /app/ | |||
| COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/database /app/database/ | |||
| # read+write access for owner/group but no write access for others | |||
| RUN chmod -R 775 /app/xp-management | |||
There was a problem hiding this comment.
- Not sure if the chmod has some unintended impact. Are we still able to build and deploy the internal image on top of this? Can it be tested prior to merging this?
- Do we need a similar change for the treatment service too?
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
79d2521
to
798bbaf
Compare
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
4588c7d
to
ece9a9b
Compare
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
c2ed0cd
to
7ba76d5
Compare
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
621b653
to
c9f045f
Compare
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
7a0d786
to
3594e17
Compare
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
3594e17
to
0f327a4
Compare
terryyylim
changed the title
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
eb8fd8b
to
2b6c32a
Compare
terryyylim
force-pushed
the
update-docker-image-perms
branch
3 times, most recently
from
92227ed
to
e55a5ca
Compare
terryyylim
force-pushed
the
update-docker-image-perms
branch
from
e55a5ca
to
2b80ed7
Compare
2 tasks
krithika369
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Left some small comments, the rest LGTM. Thanks @terryyylim !
Dockerfile
Outdated
| @@ -19,8 +35,10 @@ RUN addgroup -S ${XP_USER_GROUP} \ | |||
| && mkdir /app \ | |||
| && chown -R ${XP_USER}:${XP_USER_GROUP} /app | |||
|
|
|||
| COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/bin/* /app/ | |||
| COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/database /app/database/ | |||
| COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/bin/experiments.yaml /app/ | |||
There was a problem hiding this comment.
Nit: Can we do COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/bin/*.yaml /app/ instead of 2 separate commands to copy the OpenAPI specs?
| @@ -34,7 +34,7 @@ lint: lint-python lint-go | |||
| .PHONY: vendor | |||
| vendor: | |||
| @echo "Fetching dependencies..." | |||
| go mod vendor | |||
| cd management-service && go mod vendor | |||
There was a problem hiding this comment.
We should probabl also add commands to vendor the common and clients modules before vendoring the management service.
| treatmentHistorySvc := services.NewTreatmentHistoryService(db) | ||
| log.Println("Initializing treatment service...") |
There was a problem hiding this comment.
These seem like Debug logs. It would be enough to just have error logs if the initialization fails. Alternatively, if we want to keep these logs, we should log them at the appropriate level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When updating the helm chart for XP Management Service caraml-dev/helm-charts#220,
Permission Deniederror was faced when trying to run the generated binary.Subsequently, we're faced with
Exec format errorwhich points to our binary file being built on Ubuntu and to be used in an Alpine image. This PR adds multi-stage builds to build our app binaries using an Alpine image and copied over to the latest layer of our Docker image to solve the issue and also make the image leaner.Which issue(s) this PR fixes:
Fixes #