Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-stage builds for Management & Treatment Services Dockerfile #66

Merged
merged 20 commits into from
Mar 14, 2023
Merged

Support multi-stage builds for Management & Treatment Services Dockerfile #66

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
40190ad
Update management dockerfile
terryyylim Mar 6, 2023
93501fe
Make binary executable
terryyylim Mar 7, 2023
d4bcd3c
Add debugging lines
terryyylim Mar 7, 2023
d3b1cf8
Combine chmod
terryyylim Mar 7, 2023
5ed7faa
Revert last change
terryyylim Mar 7, 2023
798bbaf
Update Treatment Service Dockerfile
terryyylim Mar 8, 2023
8ffcfbd
Remove additional updates
terryyylim Mar 8, 2023
b093657
Update Dockerfile deps
terryyylim Mar 8, 2023
b44bf53
Update ln
terryyylim Mar 8, 2023
ece9a9b
Use debian
terryyylim Mar 8, 2023
7ba76d5
Just use ubuntu
terryyylim Mar 8, 2023
fe4bf47
Add multi-stage build
terryyylim Mar 9, 2023
c9f045f
Update workflow versions
terryyylim Mar 9, 2023
6752273
Update CMD...
terryyylim Mar 9, 2023
0f327a4
Update Treatment Service Dockerfile and deps
terryyylim Mar 10, 2023
f49a433
Make Management Service Dockerfile multi-step build
terryyylim Mar 10, 2023
2b6c32a
Remove binary download step in release workflow
terryyylim Mar 10, 2023
da86605
Copy API specs
terryyylim Mar 10, 2023
2b80ed7
Standardize schema file copy
terryyylim Mar 11, 2023
59f7ab4
Address PR comments
terryyylim Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ FROM alpine:latest

# Install bash
USER root
RUN apk add --no-cache bash
RUN apk add --no-cache bash libc6-compat

ARG API_BIN_NAME=xp-management
ARG XP_UI_DIST_PATH=ui/build
Expand All @@ -21,6 +21,8 @@ RUN addgroup -S ${XP_USER_GROUP} \

COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/bin/* /app/
COPY --chown=${XP_USER}:${XP_USER_GROUP} management-service/database /app/database/
# read+write access for owner/group but no write access for others
RUN chmod -R 775 /app/xp-management
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Not sure if the chmod has some unintended impact. Are we still able to build and deploy the internal image on top of this? Can it be tested prior to merging this?
  • Do we need a similar change for the treatment service too?


USER ${XP_USER}
WORKDIR /app
Expand Down