share menu tags fixed #1174
Merged
share menu tags fixed #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfix22
approved these changes
Feb 23, 2021
|
Dope 👌 |
|
@all-contributors add @adghayes for code |
|
@repo-ranger[bot] Your .all-contributorsrc cannot contain more than 15 files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when tweet and imgur buttons were merged in #1158 to ShareMenu component, tags were copied and pasted from the ExportMenu component. duplicate id tags were causing integration tests to fail. id and other tags updated to correspond to "share" rather than "export"
notes: there are no integration tests for the new ShareMenu component. also, the integration test for downloading images is failing and outdated, although it is skipped and not a part of CI so low priority
Closes #1171