Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): support for node 12 #1253

Merged
merged 2 commits into from
Jun 2, 2020
Merged

feat(project): support for node 12 #1253

merged 2 commits into from
Jun 2, 2020

Conversation

tay1orjones
Copy link
Member

Closes #736

Summary

Change List (commits, features, bugs, etc)

  • Update engines, vscode debugging settings, and nvmrc to Node 12.
  • Updates babel deps to fix issue with Netlify builds and a dep version collision that Carbon ran into earlier this week - feat(project): update babel for Node v12.17 carbon#6148 and was also present in our dep tree.
  • Remove weak as it is incompatible with Node 12, and we already have weak-napi which serves the same purpose for Jest's --detectLeaks flag.

Acceptance Test (how to verify the PR)

  • Status checks should pass
  • Pull down the branch, kick off a build with yarn:
  • Ensure tests pass and the build outputs as expected

Copy link
Contributor

@scottdickerson scottdickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tay1orjones
Copy link
Member Author

A bit more context on this heap out of memory issue: it's a storybook issue with terser and react-docgen. It should be totally resolved in v6, but upgrading to Node 12 is a workaround.

storybookjs/storybook#6408

@netlify
Copy link

netlify bot commented Jun 1, 2020

Deploy preview for carbon-addons-iot-react ready!

Built with commit f0537ec

https://deploy-preview-1253--carbon-addons-iot-react.netlify.app

@tay1orjones tay1orjones merged commit 9a11db2 into master Jun 2, 2020
@tay1orjones tay1orjones deleted the node-12 branch June 2, 2020 19:21
@tay1orjones
Copy link
Member Author

🎉 This PR is included in version 2.82.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[node] v12 support
3 participants