-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(idlelogoutconfirmationmodal): Fixing an issue in the idle timer logic when query parameters are appended to the page #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e current url excluding the query parameters to fix an issue where query parameters may be added to the page without a page reload, which would cause the `useEffect` to restart because it has the logout and inactivityLogout URLs as dependencies.
✅ Deploy Preview for carbon-addons-iot-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
herleraja
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e errors if `surveyData` becomes null after in subsequent component re-renders
cgirani
approved these changes
Mar 22, 2023
davidicus
approved these changes
Mar 22, 2023
url.searchParams.append('originHref', window.location.href); | ||
url.searchParams.append( | ||
'originHref', | ||
[window.location.protocol, '//', window.location.host, window.location.pathname].join('') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future I would prefer a template literal here.
Suggested change
[window.location.protocol, '//', window.location.host, window.location.pathname].join('') | |
`${window.location.protocol}//${window.location.host}${window.location.pathname}` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Summary
Change List (commits, features, bugs, etc)
originHref
parameter to be added to the logout URLs in such a way that the current page's query parameters are not included. An easier solution would be to just removeoriginHref
for good, since MAS is no longer using it, but we cannot assume that other consumers of the component aren't using it, so it is better to keep it in order to not introduce breaking changes.surveyData
to avoid runtime errors if this property becomes null in subsequent component re-renders.Acceptance Test (how to verify the PR)
window.history.replaceState(undefined, 'XXXX', window.location.href + "?tab=x")
. Wait for the idle timeout dialog to pop up and notice that the countdown happens normally, i.e. should keep decreasing by 1s. No frozen countdown number is expected.Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.