fix(heatmap-choropleth):legend hidden when data array is empty (#1763)

carbon-design-system · Feb 26, 2024 · 25274d7 · 25274d7
1 parent 7f9cade
commit 25274d7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/core/src/charts/choropleth.ts b/packages/core/src/charts/choropleth.ts
@@ -90,7 +90,8 @@ export class ExperimentalChoroplethChart extends Chart {
 
 		const isLegendEnabled =
 			getProperty(configs, 'legend', 'enabled') !== false &&
-			this.model.getOptions().legend.enabled !== false
+			this.model.getOptions().legend.enabled !== false &&
+			this.model.getData().length > 0
 
 		// Decide the position of the legend in reference to the chart
 		const fullFrameComponentDirection = LayoutDirection.COLUMN_REVERSE

diff --git a/packages/core/src/charts/heatmap.ts b/packages/core/src/charts/heatmap.ts
@@ -95,7 +95,8 @@ export class HeatmapChart extends AxisChart {
 
 		const isLegendEnabled =
 			getProperty(configs, 'legend', 'enabled') !== false &&
-			this.model.getOptions().legend.enabled !== false
+			this.model.getOptions().legend.enabled !== false &&
+			this.model.getData().length > 0
 
 		// Decide the position of the legend in reference to the chart
 		const fullFrameComponentDirection = LayoutDirection.COLUMN_REVERSE