fix(lerna): lerna version doesn't know we are sharing eslintignore file #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le in .vscode/settings.json (and shouldn't care about prettier in the first place)
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nstuyvesant
restored the
fix-lerna-so-it-knows-where-prettier-ignore-file-is
branch
nstuyvesant
deleted the
fix-lerna-so-it-knows-where-prettier-ignore-file-is
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
lerna versionfor some unknown reason messes with prettier. Because prettier's ignore is set in .vscode/settings.json (and points to eslint's ignore file), it tries to parse yarn.lock. This PR creates a prettier ignore file that is identical to the eslint ignore file so lerna knows not to parse yarn.lock.