Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(umd): close issue 1643 - UMD bundle not generated #1644

Merged
merged 6 commits into from
Aug 9, 2023
Merged

fix(umd): close issue 1643 - UMD bundle not generated #1644

merged 6 commits into from
Aug 9, 2023

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Aug 8, 2023 •
edited

Problem solved

Updates

  • Setup a separate vite config to generate UMD. This was necessary because you cannot have multiple entry points to the library for UMD. Those entry points were necessary for the namespaces like /interfaces, /components, etc.
  • Updated core's package.json so the UMD bundle is properly exported
  • UMD bundle includes dependencies so it can work properly in a standalone web page
  • Updated the vanilla JS documentation to align with the configuration
  • Bump dependencies within semver

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners August 8, 2023 17:23
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team August 8, 2023 17:23
@netlify
Copy link

netlify bot commented Aug 8, 2023 •
edited

✅ Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit ebbbafd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/64d3c64b277b9200089c1492
😎 Deploy Preview https://deploy-preview-1644--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 8, 2023 •
edited

✅ Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit ebbbafd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/64d3c64b78c446000831c606
😎 Deploy Preview https://deploy-preview-1644--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 8, 2023 •
edited

✅ Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit ebbbafd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/64d3c64bdc94f30008a0752b
😎 Deploy Preview https://deploy-preview-1644--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

theiliad
theiliad approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit d0313dc into carbon-design-system:master Aug 9, 2023
1 of 4 checks passed
@theiliad theiliad deleted the fix-umd-issue-1643 branch August 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

@Akshat55 Akshat55 Awaiting requested review from Akshat55

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: UMD bundle for core not getting built
2 participants
@nstuyvesant @theiliad