Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(umd): close issue 1643 - UMD bundle not generated #1644

Merged
merged 6 commits into from
Aug 9, 2023
Merged

fix(umd): close issue 1643 - UMD bundle not generated #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3323175
fix(umd): close issue 1643 - UMD bundle not generated
nstuyvesant Aug 8, 2023
232963f
chore(app): bump vite, @babel/core, @typescript*, d3-cloud, @rushstac…
nstuyvesant Aug 8, 2023
644d306
fix(storybook): expects default vite config name
nstuyvesant Aug 8, 2023
cba034e
chore(storybook): bug fixes
nstuyvesant Aug 9, 2023
2d21414
fix(umd): correct name from CarbonCharts to Charts to avoid breaking …
nstuyvesant Aug 9, 2023
ebbbafd
fix(stories): update to reflect orig variable name
nstuyvesant Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 13 additions & 13 deletions packages/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,36 +53,36 @@
"@angular/forms": "^16.1.8",
"@angular/platform-browser": "^16.1.8",
"@angular/platform-browser-dynamic": "^16.1.8",
"@babel/core": "^7.22.9",
"@babel/core": "^7.22.10",
"@carbon/icon-helpers": "^10.44.0",
"@carbon/icons": "^11.24.0",
"@stackblitz/sdk": "^1.9.0",
"@storybook/addon-essentials": "^7.2.1",
"@storybook/addon-interactions": "^7.2.1",
"@storybook/addon-links": "^7.2.1",
"@storybook/angular": "^7.2.1",
"@storybook/blocks": "^7.2.1",
"@storybook/manager-api": "^7.2.1",
"@storybook/addon-essentials": "^7.2.2",
"@storybook/addon-interactions": "^7.2.2",
"@storybook/addon-links": "^7.2.2",
"@storybook/angular": "^7.2.2",
"@storybook/blocks": "^7.2.2",
"@storybook/manager-api": "^7.2.2",
"@storybook/testing-library": "^0.2.0",
"@storybook/theming": "^7.2.1",
"@storybook/theming": "^7.2.2",
"@types/carbon__icon-helpers": "^10.7.2",
"@typescript-eslint/eslint-plugin": "^6.2.1",
"@typescript-eslint/parser": "^6.2.1",
"@typescript-eslint/eslint-plugin": "^6.3.0",
"@typescript-eslint/parser": "^6.3.0",
"concurrently": "^8.2.0",
"d3": "^7.8.5",
"d3-cloud": "^1.2.5",
"d3-cloud": "^1.2.7",
"d3-sankey": "^0.12.3",
"downlevel-dts": "^0.11.0",
"eslint": "^8.46.0",
"eslint-config-prettier": "^9.0.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-storybook": "^0.6.13",
"ng-packagr": "^16.1.0",
"ng-packagr": "^16.2.0",
"prettier-eslint": "^15.0.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"rxjs": "~7.8.1",
"storybook": "^7.2.1",
"storybook": "^7.2.2",
"style-loader": "^3.3.3",
"typescript": "~5.1.6",
"zone.js": "~0.13.1"
Expand Down
55 changes: 25 additions & 30 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.11.17",
"description": "Carbon Charts component library",
"module": "./dist/index.mjs",
"main": "./dist/index.js",
"main": "./dist/umd/bundle.umd.js",
"types": "./dist/index.d.ts",
"exports": {
"./package.json": "./package.json",
Expand All @@ -15,38 +15,33 @@
"types": "./dist/index.d.ts",
"browser": {
"import": "./dist/index.mjs",
"require": "./dist/index.js"
"require": "./dist/umd/bundle.umd.js"
},
"node": {
"import": "./dist/index.mjs",
"require": "./dist/index.js"
"require": "./dist/umd/bundle.umd.js"
}
},
"./components": {
"types": "./dist/components/index.d.ts",
"import": "./dist/components/index.mjs",
"require": "./dist/components/index.js"
"import": "./dist/components/index.mjs"
},
"./demo/styles.css": "./dist/demo/styles.css",
"./demo": {
"types": "./dist/demo/index.d.ts",
"import": "./dist/demo/index.mjs",
"require": "./dist/demo/index.js"
"import": "./dist/demo/index.mjs"
},
"./interfaces": {
"types": "./dist/interfaces/index.d.ts",
"import": "./dist/interfaces/index.mjs",
"require": "./dist/interfaces/index.js"
"import": "./dist/interfaces/index.mjs"
},
"./model": {
"types": "./dist/model/index.d.ts",
"import": "./dist/model/index.mjs",
"require": "./dist/model/index.js"
"import": "./dist/model/index.mjs"
},
"./services": {
"types": "./dist/services/index.d.ts",
"import": "./dist/services/index.mjs",
"require": "./dist/services/index.js"
"import": "./dist/services/index.mjs"
}
},
"files": [
Expand All @@ -63,7 +58,7 @@
"file:css:demo": "sass scss/demos.scss dist/demo/styles.css --load-path=./node_modules --load-path=../../node_modules",
"file:downlevel:dts": "downlevel-dts dist dist",
"postbundle": "concurrently \"yarn:file:*\"",
"build:package": "vite build && yarn postbundle && cp dist/styles*.css* ./",
"build:package": "vite build && vite build -c ./vite.umd.config.ts && yarn postbundle && cp dist/styles*.css* ./",
"demo:docs": "typedoc ./src/index.ts --out ./demo/bundle/documentation",
"demo:storybook": "storybook build -o demo/bundle --quiet",
"build:demo": "concurrently \"yarn:demo:*\"",
Expand All @@ -88,7 +83,7 @@
"@carbon/utils-position": "^1.1.4",
"carbon-components": "^10.58.8",
"d3": "^7.8.5",
"d3-cloud": "^1.2.5",
"d3-cloud": "^1.2.7",
"d3-sankey": "^0.12.3",
"date-fns": "^2.30.0",
"html-to-image": "^1.11.11",
Expand All @@ -110,29 +105,29 @@
}
},
"devDependencies": {
"@babel/core": "^7.22.9",
"@babel/core": "^7.22.10",
"@carbon/import-once": "^10.7.0",
"@carbon/layout": "^11.18.0",
"@carbon/styles": "^1.35.0",
"@carbon/themes": "^11.23.0",
"@rushstack/eslint-patch": "^1.3.2",
"@rushstack/eslint-patch": "^1.3.3",
"@stackblitz/sdk": "^1.9.0",
"@storybook/addon-essentials": "^7.2.1",
"@storybook/addon-interactions": "^7.2.1",
"@storybook/addon-links": "^7.2.1",
"@storybook/blocks": "^7.2.1",
"@storybook/html": "^7.2.1",
"@storybook/html-vite": "^7.2.1",
"@storybook/manager-api": "^7.2.1",
"@storybook/addon-essentials": "^7.2.2",
"@storybook/addon-interactions": "^7.2.2",
"@storybook/addon-links": "^7.2.2",
"@storybook/blocks": "^7.2.2",
"@storybook/html": "^7.2.2",
"@storybook/html-vite": "^7.2.2",
"@storybook/manager-api": "^7.2.2",
"@storybook/testing-library": "^0.2.0",
"@storybook/theming": "^7.2.1",
"@storybook/theming": "^7.2.2",
"@types/d3": "^7.4.0",
"@types/d3-cloud": "^1.2.5",
"@types/d3-sankey": "^0.12.1",
"@types/lodash-es": "^4.17.8",
"@types/topojson": "^3.2.3",
"@typescript-eslint/eslint-plugin": "^6.2.1",
"@typescript-eslint/parser": "^6.2.1",
"@typescript-eslint/eslint-plugin": "^6.3.0",
"@typescript-eslint/parser": "^6.3.0",
"concurrently": "^8.2.0",
"downlevel-dts": "^0.11.0",
"eslint": "^8.46.0",
Expand All @@ -143,11 +138,11 @@
"react-dom": "^18.2.0",
"resize-observer-polyfill": "^1.5.1",
"sass": "^1.64.2",
"storybook": "^7.2.1",
"storybook": "^7.2.2",
"typedoc": "^0.24.8",
"typescript": "^5.1.6",
"vite": "^4.4.8",
"vite-plugin-dts": "^3.5.0",
"vite": "^4.4.9",
"vite-plugin-dts": "^3.5.1",
"vitest": "^0.34.1"
},
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/stories/getting-started/vanilla-javascript.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ new StackedBarChart(chartHolder, {
<body>
<div id="my-bar-chart"></div>

<script src="https://unpkg.com/@carbon/charts/bundle.js"></script>
<script src="https://unpkg.com/@carbon/charts/dist/umd/bundle.umd.js"></script>

<script>
// grab chart holder DOM element
Expand Down
2 changes: 1 addition & 1 deletion packages/core/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default defineConfig({
'services/index': 'src/services/index.ts',
'demo/index': 'src/demo/index.ts'
},
name: 'CarbonCharts'
formats: ['es']
},
rollupOptions: {
external: ['d3', 'd3-cloud', 'd3-sankey'] // d3-cloud and d3-sankey are not included in d3
Expand Down
38 changes: 38 additions & 0 deletions packages/core/vite.umd.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { fileURLToPath } from 'url'
import { defineConfig } from 'vite'

export default defineConfig({
build: {
outDir: 'dist/umd',
sourcemap: true,
chunkSizeWarningLimit: 600,
lib: {
entry: 'src/index.ts',
formats: ['umd'],
fileName: 'bundle',
name: 'Charts'
}
},
optimizeDeps: {
include: [ // everything included in UMD bundle
'@carbon/colors',
'@carbon/utils-position',
'carbon-components',
'd3',
'd3-cloud',
'd3-sankey',
'date-fns', // make peerDependency and externalize in next major
'html-to-image',
'lodash-es' // make peerDependency and externalize in next major (or replace with modern TypeScript alternatives)
],
exclude: [
'@carbon/telemetry' // prevent Storybook issue
]
},
resolve: {
alias: {
'@': fileURLToPath(new URL('./src', import.meta.url))
}
},
plugins: []
})
38 changes: 19 additions & 19 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,36 +51,36 @@
"react-dom": "^16.0.0 || ^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@babel/core": "^7.22.9",
"@babel/core": "^7.22.10",
"@babel/plugin-external-helpers": "^7.22.5",
"@babel/plugin-proposal-object-rest-spread": "^7.20.7",
"@babel/plugin-transform-react-jsx": "^7.22.5",
"@babel/preset-env": "^7.22.9",
"@babel/preset-env": "^7.22.10",
"@babel/preset-react": "^7.22.5",
"@babel/preset-typescript": "^7.22.5",
"@rushstack/eslint-patch": "^1.3.2",
"@rushstack/eslint-patch": "^1.3.3",
"@stackblitz/sdk": "1.9.0",
"@storybook/addon-essentials": "^7.2.1",
"@storybook/addon-interactions": "^7.2.1",
"@storybook/addon-links": "^7.2.1",
"@storybook/blocks": "^7.2.1",
"@storybook/manager-api": "^7.2.1",
"@storybook/react": "^7.2.1",
"@storybook/react-vite": "^7.2.1",
"@storybook/react-webpack5": "^7.2.1",
"@storybook/addon-essentials": "^7.2.2",
"@storybook/addon-interactions": "^7.2.2",
"@storybook/addon-links": "^7.2.2",
"@storybook/blocks": "^7.2.2",
"@storybook/manager-api": "^7.2.2",
"@storybook/react": "^7.2.2",
"@storybook/react-vite": "^7.2.2",
"@storybook/react-webpack5": "^7.2.2",
"@storybook/testing-library": "^0.2.0",
"@storybook/theming": "^7.2.1",
"@storybook/theming": "^7.2.2",
"@types/carbon__icons-react": "^11.20.0",
"@types/react": "^18.2.18",
"@types/react": "^18.2.19",
"@types/react-dom": "^18.2.7",
"@typescript-eslint/eslint-plugin": "^6.2.1",
"@typescript-eslint/parser": "^6.2.1",
"@typescript-eslint/eslint-plugin": "^6.3.0",
"@typescript-eslint/parser": "^6.3.0",
"@vitejs/plugin-react": "^4.0.4",
"classnames": "^2.3.2",
"concurrently": "^8.2.0",
"css-loader": "6.8.1",
"d3": "^7.8.5",
"d3-cloud": "^1.2.5",
"d3-cloud": "^1.2.7",
"d3-sankey": "^0.12.3",
"downlevel-dts": "^0.11.0",
"eslint": "^8.46.0",
Expand All @@ -91,11 +91,11 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"sass": "^1.64.2",
"storybook": "^7.2.1",
"storybook": "^7.2.2",
"style-loader": "^3.3.3",
"typescript": "^5.1.6",
"vite": "^4.4.8",
"vite-plugin-dts": "^3.5.0",
"vite": "^4.4.9",
"vite-plugin-dts": "^3.5.1",
"webpack": "5.88.2"
},
"publishConfig": {
Expand Down
26 changes: 13 additions & 13 deletions packages/svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,23 +47,23 @@
},
"devDependencies": {
"@stackblitz/sdk": "^1.9.0",
"@storybook/addon-essentials": "^7.2.1",
"@storybook/addon-interactions": "^7.2.1",
"@storybook/addon-links": "^7.2.1",
"@storybook/blocks": "^7.2.1",
"@storybook/manager-api": "^7.2.1",
"@storybook/svelte": "^7.2.1",
"@storybook/sveltekit": "^7.2.1",
"@storybook/addon-essentials": "^7.2.2",
"@storybook/addon-interactions": "^7.2.2",
"@storybook/addon-links": "^7.2.2",
"@storybook/blocks": "^7.2.2",
"@storybook/manager-api": "^7.2.2",
"@storybook/svelte": "^7.2.2",
"@storybook/sveltekit": "^7.2.2",
"@storybook/testing-library": "^0.2.0",
"@storybook/theming": "^7.2.1",
"@storybook/theming": "^7.2.2",
"@sveltejs/adapter-auto": "^2.1.0",
"@sveltejs/kit": "^1.22.4",
"@sveltejs/package": "^2.2.0",
"@typescript-eslint/eslint-plugin": "^6.2.1",
"@typescript-eslint/parser": "^6.2.1",
"@typescript-eslint/eslint-plugin": "^6.3.0",
"@typescript-eslint/parser": "^6.3.0",
"concurrently": "^8.2.0",
"d3": "^7.8.5",
"d3-cloud": "^1.2.5",
"d3-cloud": "^1.2.7",
"d3-sankey": "^0.12.3",
"eslint": "^8.46.0",
"eslint-config-prettier": "^9.0.0",
Expand All @@ -73,12 +73,12 @@
"publint": "^0.2.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"storybook": "^7.2.1",
"storybook": "^7.2.2",
"svelte": "^4.1.2",
"svelte-check": "^3.4.6",
"tslib": "^2.6.1",
"typescript": "^5.1.6",
"vite": "^4.4.8"
"vite": "^4.4.9"
},
"publishConfig": {
"access": "public"
Expand Down